Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Restyle SidebarMenuPage #9088

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[MS] Restyle SidebarMenuPage #9088

merged 1 commit into from
Dec 5, 2024

Conversation

fabienSvtr
Copy link
Contributor

@fabienSvtr fabienSvtr commented Dec 2, 2024 •
edited
Loading

Describe your changes

  • Added dropdown feature to toggle visibility
  • Rearranged style
  • Add animation on click
sidebar.mov

Checklist

Before you submit this pull request, please make sure to:

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description
  • Link any dependent pull request in the description

closes #8980
closes #8700

@fabienSvtr fabienSvtr requested a review from a team as a code owner December 2, 2024 16:16
NicoTuxx
NicoTuxx requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@NicoTuxx NicoTuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style seems broken for buttons in "manage my organization"

image

@fabienSvtr fabienSvtr force-pushed the ms-restyle-sidebar branch 5 times, most recently from cdce6ab to ab95660 Compare December 4, 2024 14:36
@fabienSvtr fabienSvtr added this pull request to the merge queue Dec 5, 2024
@fabienSvtr fabienSvtr removed this pull request from the merge queue due to a manual request Dec 5, 2024
@fabienSvtr fabienSvtr enabled auto-merge December 5, 2024 08:34
@fabienSvtr fabienSvtr added this pull request to the merge queue Dec 5, 2024
Merged via the queue into master with commit b21a420 Dec 5, 2024
13 checks passed
@fabienSvtr fabienSvtr deleted the ms-restyle-sidebar branch December 5, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoTuxx NicoTuxx NicoTuxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restyle SidebarMenu Sidebar icons of Workspaces and Favourites buttons not vertically centered
2 participants
@fabienSvtr @NicoTuxx